Verification API: Interactive sample, javadoc enhancements and code cleaning #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s managed by Builders pattern
JPPortier
requested review from
Dovchik,
650elx,
krogers0607 and
asein-sinch
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned Manifest Files |
asein-sinch
reviewed
Feb 6, 2024
client/src/main/com/sinch/sdk/domains/verification/adapters/StatusService.java
Show resolved
Hide resolved
client/src/main/com/sinch/sdk/domains/verification/adapters/VerificationsService.java
Show resolved
Hide resolved
client/src/main/com/sinch/sdk/domains/verification/models/NumberIdentity.java
Show resolved
Hide resolved
openapi-contracts/src/test/resources/domains/verification/v1/error-response.json
Show resolved
Hide resolved
client/src/test/java/com/sinch/sdk/models/E164PhoneNumberTest.java
Outdated
Show resolved
Hide resolved
sample-app/src/main/java/com/sinch/sample/verification/VerificationsSampleFlowInteractive.java
Outdated
Show resolved
Hide resolved
sample-app/src/main/java/com/sinch/sample/verification/VerificationsSampleFlowInteractive.java
Show resolved
Hide resolved
asein-sinch
reviewed
Feb 6, 2024
...inch/sdk/domains/verification/models/requests/StartVerificationCalloutRequestParameters.java
Outdated
Show resolved
Hide resolved
asein-sinch
reviewed
Feb 6, 2024
sample-app/src/main/java/com/sinch/sample/verification/verifications/Start.java
Show resolved
Hide resolved
asein-sinch
reviewed
Feb 6, 2024
client/src/test/java/com/sinch/sdk/models/E164PhoneNumberTest.java
Outdated
Show resolved
Hide resolved
asein-sinch
reviewed
Feb 6, 2024
...n/com/sinch/sdk/domains/verification/models/requests/StartVerificationRequestParameters.java
Outdated
Show resolved
Hide resolved
asein-sinch
approved these changes
Feb 6, 2024
JPPortier
force-pushed
the
DEVEXP-218-verification-api-code-cleaning
branch
from
acded73 to
a5d06fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.