Sms delivery reports #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tBatch* (DeliveryReport are not dedicated by webhooks and shared with DeliveryReport endpoints)
…n place webhooks dedicated type
…et delivery report by batch'
JPPortier
requested review from
Dovchik,
650elx,
krogers0607 and
asein-sinch
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned Manifest Files |
… dynamic to accept generic in place of 'String' values only
Dovchik
approved these changes
Nov 10, 2023
Comment on lines
+38
to
+39
| private Configuration configuration; | ||
| private DeliveryReportsApi api; |
There was a problem hiding this comment.
final allows to set the variable only once anywhere, be it constructor, or another method. Does it makes sense to mark this variables as final in this context?
There was a problem hiding this comment.
It should yes.
But I'm facing an issue (not yet finalized) due to unit testing and mocking library: when set to final mocking lib is not able to set variables and test execution are facing null pointer.
I'll have to take time to fix this...
JPPortier
added a commit
that referenced
this pull request
Nov 16, 2023
* feat: SMS: Delivery Reports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeliveryReportenum fortypetoDeliveryReportTypeget/getForNumberandlist