DEVEXP-223: SMS / support service plan ID #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed credentials/contexts
JPPortier
requested review from
Dovchik,
650elx,
krogers0607 and
asein-sinch
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned Manifest Files |
asein-sinch
reviewed
Feb 23, 2024
client/src/main/com/sinch/sdk/auth/adapters/BearerAuthManager.java
Outdated
Show resolved
Hide resolved
client/src/main/com/sinch/sdk/domains/numbers/adapters/NumbersService.java
Show resolved
Hide resolved
client/src/main/com/sinch/sdk/domains/sms/adapters/SMSService.java
Outdated
Show resolved
Hide resolved
client/src/test/java/com/sinch/sdk/domains/voice/adapters/VoiceServiceTest.java
Show resolved
Hide resolved
asein-sinch
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support service plan ID/token at configuration level
When defined: super-sed unified credentials and switch to service plan usage
The last commit is THE simple feature support
All previous commit are refactoring level and enable to:
This refactoring will enable incoming task supporting multiple credentials