Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename 'VerificationStatusService.get' functions to dedicat… #66

Merged

Conversation

JPPortier
Copy link
Contributor

…ed function names

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

Copy link

@asein-sinch asein-sinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although Java supports overloading, I agree it's best to have different method names since the API endpoints are on different paths: it makes a clear mapping with the developer documentation 👍

@JPPortier JPPortier merged commit 43b990f into main Mar 18, 2024
5 checks passed
@JPPortier JPPortier deleted the DEVEXP-331-rename-verification-api-to-cross-sdk-naming branch March 18, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants