Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVEXP-165 sms groups #9

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

JPPortier
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 95249e7.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Manifest Files

Copy link

@650elx 650elx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean 👌

Two things we could put into backlog after merging this:

  1. Tests for the samples. Examples tend to go out of date really quickly.
  2. Making those samples smaller and refactoring some of this code into e2e tests.

@JPPortier
Copy link
Contributor Author

Two things we could put into backlog after merging this:
...
Created ticket DEVEXP-196

@JPPortier JPPortier merged commit 02968ac into DEVEXP-164-inbounds Nov 16, 2023
2 checks passed
@JPPortier JPPortier deleted the DEVEXP-165-sms-groups branch November 16, 2023 10:07
@650elx 650elx mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants