Do not transform to a Date object in the plugin (#41)

sinch · Mar 18, 2024 · a3a37be · a3a37be
1 parent 5e06b79
commit a3a37be
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/sdk-client/src/plugins/timezone/timezone.response.ts b/packages/sdk-client/src/plugins/timezone/timezone.response.ts
@@ -41,7 +41,7 @@ implements ResponsePlugin<V | Record<string, any>> {
                     timestampValue = timestampValue + 'Z';
                   }
                 }
-                res[key] = new Date(timestampValue);
+                res[key] = timestampValue;
               }
             }
           }

diff --git a/packages/sdk-client/tests/plugins/timezone/timezone.response.test.ts b/packages/sdk-client/tests/plugins/timezone/timezone.response.test.ts
@@ -30,7 +30,7 @@ describe('Timezone response plugin', () => {
     const runner = plugin.load(context);
     const result = await runner.transform(apiResponse);
 
-    expect(result.timestamp).toStrictEqual(new Date(TIMESTAMP_WITH_TIMEZONE));
+    expect(result.timestamp).toBe(TIMESTAMP_WITH_TIMEZONE);
   });
 
   it('should NOT update the timestamp if the timezone is already there with "Z" format', async () => {
@@ -41,7 +41,7 @@ describe('Timezone response plugin', () => {
     const runner = plugin.load(context);
     const result = await runner.transform(apiResponse);
 
-    expect(result.timestamp).toStrictEqual(new Date(TIMESTAMP_WITH_TIMEZONE));
+    expect(result.timestamp).toBe(TIMESTAMP_WITH_TIMEZONE);
   });
 
   it('should update the timestamp if the timezone is already there but with "+XX format"', async () => {
@@ -52,7 +52,7 @@ describe('Timezone response plugin', () => {
     const runner = plugin.load(context);
     const result = await runner.transform(apiResponse);
 
-    expect(result.timestamp).toStrictEqual(new Date(TIMESTAMP_WITH_TIMEZONE_HOURS_MINUTES));
+    expect(result.timestamp).toBe(TIMESTAMP_WITH_TIMEZONE_HOURS_MINUTES);
   });
 
   it('should NOT update the timestamp if the timezone is already there with "+XX:XX format"', async () => {
@@ -63,7 +63,7 @@ describe('Timezone response plugin', () => {
     const runner = plugin.load(context);
     const result = await runner.transform(apiResponse);
 
-    expect(result.timestamp).toStrictEqual(new Date(TIMESTAMP_WITH_TIMEZONE_HOURS_MINUTES));
+    expect(result.timestamp).toBe(TIMESTAMP_WITH_TIMEZONE_HOURS_MINUTES);
   });
 
   it('should NOT update the timestamp if the operationId if not listed', async () => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -41,7 +41,7 @@ implements ResponsePlugin<V | Record<string, any>> { @@
                         timestampValue = timestampValue + 'Z';
                       }
                     }
-                    res[key] = new Date(timestampValue);
+                    res[key] = timestampValue;
                   }
                 }
               }
@@ Expand Down @@