fix: use ISO format for Date serialization

sinch · Dec 12, 2024 · b7c1b4a · b7c1b4a
1 parent bed6210
commit b7c1b4a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 13 deletions.
diff --git a/packages/mailgun/src/models/v1/emails/request/helper.ts b/packages/mailgun/src/models/v1/emails/request/helper.ts
@@ -7,7 +7,11 @@ export const appendFilteredPropertiesToFormData = (
 ) => {
   for (const [key, value] of Object.entries(obj)) {
     if (key.startsWith(prefix) && value != null) {
-      formData.append(key, String(value));
+      if (value instanceof Date) {
+        formData.append(key, value.toISOString());
+      } else {
+        formData.append(key, String(value));
+      }
     }
   }
 };
diff --git a/packages/mailgun/tests/models/v1/emails/request/helper.test.ts b/packages/mailgun/tests/models/v1/emails/request/helper.test.ts
@@ -18,22 +18,21 @@ describe('appendFilteredPropertiesToFormData', () => {
     const obj = {
       'o:dkim': true,
       'o:tracking': 'yes',
-      // 'v:first_name': 'John',
-      // 'v:last_name': 'Smith',
-      // 'v:my_message_id': '123',
-      // 'v:date1': '2024-06-06T13:42:42',
-      'v:date2': new Date('2024-06-06T13:42:42'),
+      'v:first_name': 'John',
+      'v:last_name': 'Smith',
+      'v:my_message_id': '123',
+      'v:date1': '2024-06-06T13:42:42Z',
+      'v:date2': new Date('2024-06-06T13:42:42Z'),
     };
 
     appendFilteredPropertiesToFormData(obj, 'v:', formData);
 
-    expect(appendSpy).toHaveBeenCalledTimes(1);
-    // expect(appendSpy).toHaveBeenCalledWith('v:first_name', 'John');
-    // expect(appendSpy).toHaveBeenCalledWith('v:last_name', 'Smith');
-    // expect(appendSpy).toHaveBeenCalledWith('v:my_message_id', '123');
-    // expect(appendSpy).toHaveBeenCalledWith('v:date1', '2024-06-06T13:42:42');
-    expect(appendSpy).toHaveBeenCalledWith('v:date2',
-      'Thu Jun 06 2024 13:42:42 GMT+0200 (Central European Summer Time)');
+    expect(appendSpy).toHaveBeenCalledTimes(5);
+    expect(appendSpy).toHaveBeenCalledWith('v:first_name', 'John');
+    expect(appendSpy).toHaveBeenCalledWith('v:last_name', 'Smith');
+    expect(appendSpy).toHaveBeenCalledWith('v:my_message_id', '123');
+    expect(appendSpy).toHaveBeenCalledWith('v:date1', '2024-06-06T13:42:42Z');
+    expect(appendSpy).toHaveBeenCalledWith('v:date2', '2024-06-06T13:42:42.000Z');
   });
 
   it('should not append properties with null or undefined values', () => {