Skip to content

Commit

Permalink
Fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
asein-sinch committed Jul 31, 2024
1 parent 2e13363 commit cfed95a
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { IpRange } from '../ip-range';
import { IpRangeRequest } from '../ip-range';

export interface CreateAccessControlListRequest {
/** Your name for the access control list entry. */
name: string;
/** Whether the access control list entry is enabled. You can use this to disable a list temporarily without deleting it. */
enabled?: boolean;
/** An array of all the IP ranges to create. */
ipRanges: Omit<IpRange, 'accessControlListId' | 'id' | 'createTime' | 'updateTime' | 'projectId'>[];
ipRanges: IpRangeRequest[];
}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export type { IpRange } from './ip-range';
export type { IpRange, IpRangeRequest } from './ip-range';
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,5 @@ export interface IpRange {
/** The ID of the access control list. */
accessControlListId?: string;
}

export type IpRangeRequest = Omit<IpRange, 'accessControlListId' | 'id' | 'createTime' | 'updateTime' | 'projectId'>;
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { IpRange } from '../../ip-range';
import { IpRangeRequest } from '../../ip-range';
import { UpdateAccessControlListRequest } from '../../update-access-control-list-request';
import { CreateAccessControlListRequest } from '../../create-access-control-list-request';

export interface AddIpRangeToAccessControlListRequestData {
/** The ID of the access control list entry. that you want to work with */
'accessControlListId': string;
/** */
'addIpRangeRequestBody': Omit<IpRange, 'accessControlListId' | 'id' | 'createTime' | 'updateTime' | 'projectId'>;
'addIpRangeRequestBody': IpRangeRequest;
}
export interface CreateAccessControlListRequestData {
/** The Access Control List details used to create an Access Control List */
Expand Down Expand Up @@ -44,5 +44,5 @@ export interface UpdateIpRangeFromAccessControlListRequestData {
/** The ID of the IP range that you want to update. */
'ipRangeId': string;
/** The IP range details used to update the IP range property from an Access Control List */
'updateIpRangeRequestBody': Omit<IpRange, 'accessControlListId' | 'id' | 'createTime' | 'updateTime' | 'projectId'>;
'updateIpRangeRequestBody': IpRangeRequest;
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { IpRange } from '../ip-range';
import { IpRangeRequest } from '../ip-range';

export interface UpdateAccessControlListRequest {
/** Your name for the access control list entry. */
name: string;
/** Whether the access control list entry is enabled. You can use this to disable a list temporarily without deleting it. */
enabled?: boolean;
/** An array of all the IP ranges to update. */
ipRanges?: Omit<IpRange, 'accessControlListId' | 'id' | 'createTime' | 'updateTime' | 'projectId'>[];
ipRanges?: IpRangeRequest[];
}
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ When('I send a request to retrieve an Access Control List', async () => {

Then('the response contains the Access Control List details', () => {
assert.equal(accessControlList.id, '01W4FFL35P4NC4K35SIPACL001');
assert.equal(accessControlList.name, 'My Access Control List');
assert.deepEqual(accessControlList.createTime, new Date('2024-06-06T14:42:42Z'));
assert.ok(accessControlList.ipRanges);
});

When('I send a request to update an Access Control List', async () => {
Expand Down

0 comments on commit cfed95a

Please sign in to comment.