Provide options for unexploded parameters

packages/numbers/src/rest/v1/active-number/active-number-api.ts

@@ -139,7 +139,9 @@ export class ActiveNumberApi extends NumbersApi {
     const listPromise = buildPageResultPromise<ActiveNumber>(
       this.client,
       requestOptionsPromise,
-      operationProperties);
+      operationProperties,
+      false,
+      ';');
 
     // Add properties to the Promise to offer the possibility to use it as an iterator
     Object.assign(

packages/numbers/src/rest/v1/available-number/available-number-api.ts

@@ -122,7 +122,7 @@ export class AvailableNumberApi extends NumbersApi {
       headers,
       body || undefined,
     );
-    const url = this.client.prepareUrl(requestOptions.basePath, requestOptions.queryParams);
+    const url = this.client.prepareUrl(requestOptions.basePath, requestOptions.queryParams, false, ';');
 
     return this.client.processCall<AvailableNumbersResponse>({
       url,

packages/sdk-client/src/api/api-client.ts

@@ -77,7 +77,7 @@ export class ApiClient {
           const prop = data[name];
           acc[name] = typeof prop.toJSON === 'function'
             ? prop.toJSON()
-            : Array.isArray(prop) ? prop.join(';') : prop.toString();
+            : Array.isArray(prop) ? prop.join(',') : prop.toString();
           return acc;
         },
         {} as { [p in keyof T]: string },
@@ -128,16 +128,18 @@ export class ApiClient {
    * @param {string} url - The base url to be used.
    * @param {Object.<string, string|undefined>} queryParameters - Key-value pair with the parameters. If the value is undefined, the key is dropped.
    * @param {boolean} repeatParamArray - create as many single parameters with each value of the array
+   * @param {string} unexplodedSeparator - the separator to use between values when `explode` is false (default is ',')
    * @return {string} The prepared URL as a string.
    */
   prepareUrl(
     url: string,
     queryParameters: { [key: string]: string | undefined } = {},
     repeatParamArray?: boolean,
+    unexplodedSeparator?: string,
   ): string {
     const queryPart = Object.keys(queryParameters)
       .filter((name) => typeof queryParameters[name] !== 'undefined')
-      .map((name) => this.formatQueryParameter(name, queryParameters, repeatParamArray))
+      .map((name) => this.formatQueryParameter(name, queryParameters, repeatParamArray, unexplodedSeparator))
       .join('&');
 
     const paramsPrefix = url.indexOf('?') > -1 ? '&' : '?';
@@ -150,20 +152,24 @@ export class ApiClient {
    * @param {string} name - The parameter name
    * @param {Object.<string, string|undefined>} queryParameters - Key-value pair with the parameters. If the value is undefined, the key is dropped.
    * @param {boolean}repeatParamArray - Create as many single parameters with each value of the array
+   * @param {string} unexplodedSeparator - the separator to use between values when `explode` is false (default is `,`)
    * @return {string} The query parameter formatted as required by the API
    */
   private formatQueryParameter = (
     name: string,
     queryParameters: { [key: string]: string | undefined } = {},
     repeatParamArray?: boolean,
+    unexplodedSeparator?: string,
   ): string => {
     const defaultFormat = `${name}=${queryParameters[name]!}`;
     if(repeatParamArray) {
       const parameterValue = queryParameters[name];
-      if (parameterValue && parameterValue.indexOf(';') > 0) {
-        const parameterValues = parameterValue.split(';');
+      if (parameterValue && parameterValue.indexOf(',') > 0) {
+        const parameterValues = parameterValue.split(',');
         return parameterValues.map((value) => `${name}=${value}`).join('&');
       }
+    } else if (unexplodedSeparator !== undefined) {
+      return defaultFormat.replaceAll(',', unexplodedSeparator);
     }
     return defaultFormat;
   };

packages/sdk-client/src/client/api-client-pagination-helper.ts

@@ -206,10 +206,13 @@ export const buildPageResultPromise = async  <T>(
   client: ApiClient,
   requestOptionsPromise: Promise<RequestOptions>,
   operationProperties: PaginatedApiProperties,
+  repeatParamArray?: boolean,
+  unexplodedSeparator?: string,
 ): Promise<PageResult<T>> => {
   // Await the promise in this async method and store the result in client so that they can be reused
   const requestOptions = await requestOptionsPromise;
-  const url = client.prepareUrl(requestOptions.basePath, requestOptions.queryParams);
+  const url = client.prepareUrl(
+    requestOptions.basePath, requestOptions.queryParams, repeatParamArray, unexplodedSeparator);
 
   return client.processCallWithPagination<T>({
     url,

packages/sdk-client/tests/api/api-client.test.ts

@@ -26,18 +26,29 @@ describe('API client', () => {
     const url = 'https://example.com';
     const parameters = {
       foo: 'fooValue',
-      bar: '1;2',
+      bar: '1,2',
       baz: undefined,
     };
     const formattedUrl = apiClient.prepareUrl(url, parameters);
+    expect(formattedUrl).toBe('https://example.com?foo=fooValue&bar=1,2');
+  });
+
+  it('should format the URL with array parameters and a custom separator', () => {
+    const url = 'https://example.com';
+    const parameters = {
+      foo: 'fooValue',
+      bar: '1,2',
+      baz: undefined,
+    };
+    const formattedUrl = apiClient.prepareUrl(url, parameters, false, ';');
     expect(formattedUrl).toBe('https://example.com?foo=fooValue&bar=1;2');
   });
 
   it('should format the URL with array parameters with repeat key', () => {
     const url = 'https://example.com';
     const parameters = {
       foo: 'fooValue',
-      bar: '1;2',
+      bar: '1,2',
       baz: undefined,
     };
     const formattedUrl = apiClient.prepareUrl(url, parameters, true);