DEVEXP-516: E2E SMS/Delivery Reports #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asein-sinch
requested review from
JPPortier,
krogers0607,
Dovchik and
650elx
as code owners
JPPortier
reviewed
Aug 20, 2024
JPPortier
approved these changes
Aug 20, 2024
asein-sinch
commented
Aug 20, 2024
packages/sms/tests/rest/v1/delivery-reports/delivery-reports.steps.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change notice: the query parameter
recipient_msisdnhas been renamedphone_numberin the request data interface to simplify the parameter comprehension.Model update:
recipientsis marked as required in the specification but it is the case only with the query parametertype=full=> it's now optional in theMessageDeliveryStatusinterface.codecan now also be a number or a list of numbers instead of a string only