DEVEXP-520: E2E Verification/Start #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asein-sinch
requested review from
JPPortier,
krogers0607,
Dovchik and
650elx
as code owners
JPPortier
reviewed
Aug 26, 2024
JPPortier
reviewed
Aug 26, 2024
| identity: { | ||
| type: 'number', | ||
| endpoint: '+17813334444', | ||
| }, | ||
| method: 'sms', |
| const verificationInitResponse: Verification.InitiateVerificationResponse | ||
| = await verificationService.verifications.start(requestData); | ||
| const startVerificationResponse: Verification.StartSmsVerificationResponse | ||
| = await verificationService.startVerifications.startSms(requestData); |
There was a problem hiding this comment.
Not fan of renaming verificationService.verifications to verificationService.startVerifications
It could have sense ( with a major breaking change), but it start to drift with other SDK's provided implementation and ID <> SDKs function mapping
There was a problem hiding this comment.
Indeed, I generated from the OAS tag, I'll update according to the confluence page
JPPortier
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of the implementation of the e2e steps, this PR starts the refactoring for the new naming convention regarding the "phone call" and "data" verifications.
I tried to make the code backward compatible by deprecating the references to the "callout" and "seamless" interfaces.
The refactoring for the reportVerification endpoint will take place with the DEVEXP-521 user story