DEVEXP-521: E2E Verification/Report #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asein-sinch
requested review from
JPPortier,
krogers0607,
Dovchik and
650elx
as code owners
JPPortier
approved these changes
Aug 27, 2024
| const getParams = this.client.extractQueryParams<ReportPhoneCallVerificationByIdentityRequestData>( | ||
| data, [] as never[]); | ||
| const headers: { [key: string]: string | undefined } = { | ||
| 'Content-Type': 'application/json; charset=UTF-8', |
There was a problem hiding this comment.
outside of the PR scope, but:
- Verification OAS file do not specify any charset, only 'application/json' and is compliant with OAS (https://spec.openapis.org/oas/v3.0.3.html#fixed-fields-10)
- 'application/json' by default mean UTF-8 (RFC chapter "3. Encoding": https://www.ietf.org/rfc/rfc4627.txt)
There was a problem hiding this comment.
Indeed, there has been a spec update from the time these files were generated.
Base automatically changed from
DEVEXP-520_E2E-Verification/Start
to
v1.2-next
August 28, 2024 08:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.