Conversation API support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPPortier
reviewed
Jan 29, 2024
Dovchik
reviewed
Jan 29, 2024
| @@ -3,10 +3,12 @@ import { Sms } from '@sinch/sms'; | |||
| import { Verification } from '@sinch/verification'; | |||
| import { SinchClientParameters } from '@sinch/sdk-client'; | |||
| import { Voice } from '@sinch/voice'; | |||
| import { ConversationDomain } from '@sinch/conversation'; | |||
There was a problem hiding this comment.
Inconsistent naming with other products: why Domain added to conversation?
There was a problem hiding this comment.
Because Conversation is already the name of an exported model
There was a problem hiding this comment.
AH, dunno, the break in consistency in top api level seems to hit me harder than on model level
Isn't it better to rename the model to ConversationModel?
There was a problem hiding this comment.
ConversationModel would then differ from the online documentation.
ConversationDomain is used only by the SinchClient to initialize the class and should not be used by the end user.
Either way it's not ideal
JPPortier
approved these changes
Jan 30, 2024
Dovchik
approved these changes
Jan 30, 2024
asein-sinch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch to be merged on
mainwhen the official documentation will be delivered