Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Add ICE to webhooks events #149

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

asein-sinch
Copy link
Collaborator

No description provided.

Copy link

@JPPortier JPPortier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but PR is having to run e2e again when mockerserver's PR with new feature definition will be merged

Not related to this PR but e2 tests are having this warn:

(node:5946) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.

(e.g.: https://github.com/sinch/sinch-sdk-node/actions/runs/11343309223/job/31545602594#step:13:28)

@asein-sinch
Copy link
Collaborator Author

Done:

  • Before the merge:
> @sinch/voice:"test:e2e"

$ cucumber-js
......................................................................
22 scenarios (22 passed)
70 steps (70 passed)
0m01.208s (executing steps: 0m01.086s)
  • After the merge
> @sinch/voice:"test:e2e"
$ cucumber-js
..........................................................................
23 scenarios (23 passed)
74 steps (74 passed)
0m01.319s (executing steps: 0m01.226s)

@asein-sinch
Copy link
Collaborator Author

Regarding the deprecation warning, I guess it comes from a transitive dependency of eslint. I'll update it to the version 9 and flat config as I did in the snippets and quickstart repo already

@asein-sinch asein-sinch merged commit b7c45c7 into v1.3-next Oct 15, 2024
4 checks passed
@asein-sinch asein-sinch deleted the Add-ICE-to-webhooks-events branch October 15, 2024 09:54
@asein-sinch asein-sinch restored the Add-ICE-to-webhooks-events branch December 14, 2024 20:46
@asein-sinch asein-sinch deleted the Add-ICE-to-webhooks-events branch December 14, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants