Mailgun release - DO NOT MERGE #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asein-sinch
requested review from
JPPortier,
krogers0607,
Dovchik and
650elx
as code owners
JPPortier
reviewed
Nov 14, 2024
packages/mailgun/src/models/v1/emails/request/override-properties/index.ts
Outdated
Show resolved
Hide resolved
packages/mailgun/src/models/v1/emails/request/override-properties/override-properties.ts
Show resolved
Hide resolved
| import { OverrideProperties } from '../override-properties'; | ||
| import FormData = require('form-data'); | ||
|
|
||
| export type MessageContentWhereHtmlContentCanBeInlineOnly = { |
There was a problem hiding this comment.
SendEmailRequestWithoutTemplateSendEmailRequestBasicSendEmailRequestSimple
?
There was a problem hiding this comment.
See the comment on the other type name ⬇️
packages/mailgun/src/models/v1/emails/request/send-email-request/send-email-request.ts
Show resolved
Hide resolved
...ages/mailgun/src/models/v1/emails/request/send-email-request-base/send-email-request-base.ts
Outdated
Show resolved
Hide resolved
packages/mailgun/src/models/v1/emails/response/get-email-response/get-email-response.ts
Outdated
Show resolved
Hide resolved
JPPortier
approved these changes
Nov 15, 2024
JPPortier
reviewed
Dec 12, 2024
packages/mailgun/src/models/v1/emails/request/override-properties/override-properties.ts
Show resolved
Hide resolved
packages/mailgun/src/models/v1/emails/request/send-email-request/send-email-request.ts
Show resolved
Hide resolved
|
Are you sure for destination branch ? |
asein-sinch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the target implementation of what should be generated from the OAS and the configuration.
There is a change in the API design, where the path parameters are now part of the request parameters and not in the request data object.
The models are also declined in a SDK version and an API version with associated transformer methods.