Feature/Elastic SIP Trunking #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPPortier
reviewed
May 13, 2024
| @@ -5,8 +5,13 @@ import FormData = require('form-data'); | |||
|
|
|||
| export enum PaginationEnum { | |||
There was a problem hiding this comment.
May be having such list + naming + comment + dedicated field names variation processing is highlighting a design to be improved: is it possible to have something like
- a common interface definition/abstraction (avoiding dedicated payload names)
- each domain is implementing it own real data to data abstraction service
And, because at domain level, it won't "hurt" to have domain logic moved from generic client to dedicated domain
JPPortier
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature branch for all the work related to the Elastic SIP Trunking SDK development