fix(Singature): verification timestamp added to the constructor

sinch · Jan 18, 2024 · d52e838 · d52e838
1 parent 3317bf0
commit d52e838
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/sinch/core/signature.py b/sinch/core/signature.py
@@ -5,12 +5,19 @@
 
 
 class Signature:
-    def __init__(self, sinch, http_method, request_data, request_uri):
+    def __init__(
+        self,
+        sinch,
+        http_method,
+        request_data,
+        request_uri,
+        signature_timestamp=None
+    ):
         self.sinch = sinch
         self.http_method = http_method
         self.content_type = 'application/json; charset=UTF-8'
         self.request_data = request_data
-        self.signature_timestamp = datetime.now(timezone.utc).isoformat()
+        self.signature_timestamp = signature_timestamp or datetime.now(timezone.utc).isoformat()
         self.request_uri = request_uri
         self.authorization_signature = None
 

diff --git a/tests/integration/test_request_signing.py b/tests/integration/test_request_signing.py
@@ -11,7 +11,8 @@ def test_request_signature(
         sinch_client_sync,
         http_method="GET",
         request_data=json.dumps({"test": "test"}),
-        request_uri="/verification/v1/verifications"
+        request_uri="/verification/v1/verifications",
+        signature_timestamp=verification_request_signature_timestamp
     )
     signature.signature_timestamp = verification_request_signature_timestamp
     signature.calculate()
@@ -30,7 +31,8 @@ def test_request_signature_using_empty_body(
         sinch_client_sync,
         http_method="POST",
         request_data=None,
-        request_uri="/verification/v1/verifications"
+        request_uri="/verification/v1/verifications",
+        signature_timestamp=verification_request_signature_timestamp
     )
     signature.signature_timestamp = verification_request_signature_timestamp
     signature.calculate()
@@ -49,7 +51,8 @@ def test_get_headers_with_signature_and_async_client(
         sinch_client_async,
         http_method="POST",
         request_data=None,
-        request_uri="/verification/v1/verifications"
+        request_uri="/verification/v1/verifications",
+        signature_timestamp=verification_request_signature_timestamp
     )
     signature.signature_timestamp = verification_request_signature_timestamp
     headers = signature.get_http_headers_with_signature()