Unified README added #16
Conversation
650elx
requested review from
Dovchik,
krogers0607,
asein-sinch and
JPPortier
as code owners
README.md
Outdated
| [](https://github.com/sinch/sinch-sdk-python/blob/main/LICENSE) | ||
|
|
||
|
|
||
| [](https://www.python.org/downloads/release/python-390/) | ||
| [](https://www.python.org/downloads/release/python-3100/) | ||
| [](https://www.python.org/downloads/release/python-3110/) | ||
| [](https://www.python.org/downloads/release/python-3120/) |
There was a problem hiding this comment.
I think it's nice to have such a fluff and personal touch in the repo so it's not worth removing in my opinion
There was a problem hiding this comment.
I'm happy to bring this stuff back :)
|
|
||
| [](https://www.sinch.com) |
There was a problem hiding this comment.
BTW, I saw in design guide that our logo is left align
There was a problem hiding this comment.
I've tried it but it looks mediocre IMO. I prefer to keep this as "center"
README.md
Outdated
| - Synchronous using `requests` HTTP library | ||
| - Asynchronous using `aiohttp` HTTP library | ||
|
|
||
| For creating custom HTTP client code, use either `Client` or `ClientAsync` client and inject your transport during initialisation: |
There was a problem hiding this comment.
It's nice to have example, maybe you can keep them?
README.md
Outdated
| @@ -1,5 +1,23 @@ | |||
| <h1 align="center"> | |||
There was a problem hiding this comment.
In my case, Nuget didn't support <h1> tag in it's markdown language renderer so I was forced to remove it.
Additionally, layout of Sinch is left aligned so maybe we can follow same guideline here?
No description provided.