[Voice] - support for the whole API #27
Conversation
650elx
requested review from
Dovchik,
krogers0607,
asein-sinch and
JPPortier
as code owners
There was a problem hiding this comment.
Good job on PR!
We have here a discrepancy of types accepted by api function and a models, I think it would be nice to unify them to reduce confusion.
Also, the test just checking the instance, it would be nice to have check response field values as well for a more robustness.
| @@ -32,6 +32,9 @@ def __init__( | |||
| self.auth_origin = "auth.sinch.com" | |||
| self.numbers_origin = "numbers.api.sinch.com" | |||
| self.verification_origin = "verification.api.sinch.com" | |||
| self.voice_applications_origin = "callingapi.sinch.com" | |||
There was a problem hiding this comment.
I think it's not used, and overrieded below, but it would be a dot after calling
| self.voice_applications_origin = "callingapi.sinch.com" | |
| self.voice_applications_origin = "calling.api.sinch.com" |
There was a problem hiding this comment.
https://developers.sinch.com/docs/voice/api-reference/voice/tag/Applications/
I think there is a separate endpoint for Applications:
url = "https://callingapi.sinch.com/v1/configuration/numbers"
Thanks! When it comes to the |
|
For the loose enum handling (aligned with our ADR) I have an investigation ticket prepared: |
DEVEXP-306
DEVEXP-299