Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: recursion error while accessing sms_domain configurable #37

Closed
wants to merge 29 commits into from
Closed

FIX: recursion error while accessing sms_domain configurable #37

wants to merge 29 commits into from

Conversation

650elx
Copy link
Contributor

@650elx 650elx commented Dec 18, 2024

No description provided.

650elx added 29 commits January 30, 2024 10:35
@650elx
feat(SMS): SMS API with service plan id WiP
c13874d
@650elx
feat(SMS): replace batch refactored
0f43109
@650elx
Merge branch 'main' into DEVEXP-261-sms-api-with-service-plan-id
442f6b5
@650elx
feat(SMS): all sms endpoints with service_plan_id refactored
dd5aeac
@650elx
Merge branch 'main' into DEVEXP-261-sms-api-with-service-plan-id
da59293
@650elx
feat(SMS): test adapted to the new interface
c0f8f7f
@650elx
WiP
9e7ac80
@650elx
test(SMS): more service plan id related e2e tests
99dcba2
@650elx
feat(SMS): more e2e tests
35bbc8d
@650elx
test(SMS): delivery reports e2e tests
fdff8d9
@650elx
test(SMS): batches e2e tests
07f4b98
@650elx
fix: style
6c54253
@650elx
fix(pagintion): missing fixture declaration
99d35a0
@650elx
test(SMS): refactor
d0287f1
@650elx
feat(CI): missing SMS environment variables definitions
71eb9c9
@650elx
Merge branch 'main' into DEVEXP-261-sms-api-with-service-plan-id
5e0f9d5
@650elx
Change auth logic based on newer ADR
204ca86
@650elx
service_plan_id comes first
519d4cb
@650elx
test(SMS): sms region property test added
f963f4c
@650elx
style: redundant indentation removed
0848ac8
@650elx
fix: typo
49bd834
@650elx
fix: align super style with other endpoints
754a91f
@650elx
fix: typo
676c507
@650elx
test(SMS): test credentials formatting for different APIs
35da17a
@650elx
sms_origin_with_service_plan_id made public
f41bc64
@650elx
fix: missing variables added
0b26622
@650elx
test: sms domain test made clearer
d62dae3
@650elx
make testing more serious
a94048e
@650elx
fix: recursion error
c746095
@650elx 650elx requested a review from Dovchik as a code owner December 18, 2024 09:27
@650elx 650elx closed this Dec 18, 2024
@asein-sinch asein-sinch deleted the fix_recursion_error branch February 25, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dovchik Dovchik Awaiting requested review from Dovchik

@krogers0607 krogers0607 Awaiting requested review from krogers0607

@asein-sinch asein-sinch Awaiting requested review from asein-sinch

@JPPortier JPPortier Awaiting requested review from JPPortier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@650elx