DEVEXP-758: SinchClient Configuration #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matsk-sinch
commented
Mar 6, 2025
matsk-sinch
commented
- Update unit tests to validate all credentials
- Update README to explain which credentials must be set for each API
- Update unit tests to validate all credentials - Update README to explain which credentials must be set for each API Signed-off-by: Jessica Matsuoka <[email protected]>
matsk-sinch
requested review from
Dovchik,
krogers0607,
asein-sinch and
JPPortier
as code owners
asein-sinch
reviewed
Mar 6, 2025
asein-sinch
approved these changes
Mar 7, 2025
JPPortier
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.