Allow disabling the hidden preferences window. #2269
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives an option under advanced settings allowing the user to disable the hidden preferences window when applying settings (i.e., adding the hide-preferences-window class when caprine opens settings). This will be disabled by default (current behavior). If enabled, you'll very briefly see the settings window flash when caprine applies a setting inside Messenger.
|
I think this is a good way to implement a workaround, rather than having users remove the |
|
Cool. I'm guessing the process is to merge is someone with merge permissions will eventually review and merge this if accepted or come back with comments if there are changes requested? I looked through the contributing guidelines below and believe this should be good for review and merge whenever someone has a chance to take a look. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives an option under advanced settings allowing the user to disable the hidden preferences window when applying settings (i.e., adding the hide-preferences-window class when caprine opens settings). This will be disabled by default (current behavior). If enabled, you'll very briefly see the settings window flash when caprine applies a setting inside Messenger.
Based on conversation here: #2265