Is it not possible to kill shelled process? #419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaggle
commented
Apr 12, 2020
Comment on lines
+33
to
+40
| test('`kill` should kill a shell process cleanly', async t => { | ||
| const subprocess = execa('sleep', ['200'], { shell: true, stdio: ['ipc'] }); | ||
|
|
||
| subprocess.kill('SIGTERM', { forceKillAfterTimeout: 2000 }); | ||
|
|
||
| await t.throwsAsync(subprocess); | ||
| t.false(isRunning(subprocess.pid)); | ||
| }) |
There was a problem hiding this comment.
This test hangs the test-suite for the duration of the sleep, waiting for the process to stop
|
This is due to #96. See my new comment on that issue. Since this is a well-known issue, I suggest this PR to be closed if this is ok with you @gaggle? |
Oh I didn't see that issue, thanks. Yes of course, this PR was just to illustrate my question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me that a process started with
shell:truedon't always get killed properly.Here I've added tests that uses Linux's sleep, and killing the non-shell version works fine but the shelled version hangs the test-suite for the 200 seconds. The sleep sits in the process list, unkilled.
Is this expected behaviour? To my understanding a shelled process should receive signals just as well as any other process, but happy to learn otherwise.