Skip to content

Commit

Permalink
Remove Firefox focus reset (#81)
Browse files Browse the repository at this point in the history
  • Loading branch information
atjn authored Aug 9, 2024
1 parent 19a3df1 commit b3b9630
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 65 deletions.
17 changes: 0 additions & 17 deletions modern-normalize.css
Original file line number Diff line number Diff line change
Expand Up @@ -171,23 +171,6 @@ button,
-webkit-appearance: button;
}

/**
Remove the inner border and padding in Firefox.
*/

::-moz-focus-inner {
border-style: none;
padding: 0;
}

/**
Restore the focus styles unset by the previous rule.
*/

:-moz-focusring {
outline: 1px dotted ButtonText;
}

/**
Remove the padding so developers are not caught out when they zero out 'fieldset' elements in all browsers.
*/
Expand Down
8 changes: 0 additions & 8 deletions test/acceptance/chrome/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,6 @@ test('Correct the inability to style clickable types in iOS and Safari.', async
.expect(Selector('[type="submit"][data-test--forms-1]').getStyleProperty('-webkit-appearance')).eql('button');
});

test('Remove the inner border and padding in Firefox.', async t => {
// `-moz-focus-inner` does not exist in Chrome
});

test('Restore the focus styles unset by the previous rule.', async t => {
// `-moz-focusring` does not exist in Chrome
});

test('Correct the padding in Firefox.', async t => {
await t
.expect(Selector('fieldset[data-test--forms-2]').getStyleProperty('padding-top')).eql('5.6px')
Expand Down
8 changes: 0 additions & 8 deletions test/acceptance/chrome/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,6 @@ test('Correct the inability to style clickable types in iOS and Safari.', async
.expect(Selector('[type="submit"][data-test--forms-1]').getStyleProperty('-webkit-appearance')).notEql('button');
});

test('Remove the inner border and padding in Firefox.', async t => {
// `-moz-focus-inner` does not exist in Chrome
});

test('Restore the focus styles unset by the previous rule.', async t => {
// `-moz-focusring` does not exist in Chrome
});

test('Correct the padding in Firefox.', async t => {
await t
.expect(Selector('fieldset[data-test--forms-2]').getStyleProperty('padding-top')).eql('5.6px')
Expand Down
8 changes: 0 additions & 8 deletions test/acceptance/firefox/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,6 @@ test('Correct the inability to style clickable types in iOS and Safari.', async
.expect(Selector('[type="submit"][data-test--forms-1]').getStyleProperty('-webkit-appearance')).eql(undefined);
});

test('Remove the inner border and padding in Firefox.', async t => {
// TODO: Pseudo-elements selector not supported by testcafe (See https://github.com/DevExpress/testcafe/issues/2813).
});

test('Restore the focus styles unset by the previous rule.', async t => {
// TODO: Pseudo-elements selector not supported by testcafe (See https://github.com/DevExpress/testcafe/issues/2813).
});

test('Correct the padding in Firefox.', async t => {
await t
.expect(Selector('fieldset[data-test--forms-2]').getStyleProperty('padding-top')).eql('5.6px')
Expand Down
8 changes: 0 additions & 8 deletions test/acceptance/firefox/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,6 @@ test('Correct the inability to style clickable types in iOS and Safari.', async
.expect(Selector('[type="submit"][data-test--forms-1]').getStyleProperty('-webkit-appearance')).eql(undefined);
});

test('Remove the inner border and padding in Firefox.', async t => {
// TODO: Pseudo-elements selector not supported by testcafe (See https://github.com/DevExpress/testcafe/issues/2813).
});

test('Restore the focus styles unset by the previous rule.', async t => {
// TODO: Pseudo-elements selector not supported by testcafe (See https://github.com/DevExpress/testcafe/issues/2813).
});

test('Correct the padding in Firefox.', async t => {
await t
.expect(Selector('fieldset[data-test--forms-2]').getStyleProperty('padding-top')).eql('5.6px')
Expand Down
8 changes: 0 additions & 8 deletions test/acceptance/safari/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,6 @@ test('Correct the inability to style clickable types in iOS and Safari.', async
.expect(Selector('[type="submit"][data-test--forms-1]').getStyleProperty('-webkit-appearance')).eql('button');
});

test('Remove the inner border and padding in Firefox.', async t => {
// `-moz-focus-inner` does not exist in Safari
});

test('Restore the focus styles unset by the previous rule.', async t => {
// `-moz-focusring` does not exist in Safari
});

test('Correct the padding in Firefox.', async t => {
await t
.expect(Selector('fieldset[data-test--forms-2]').getStyleProperty('padding-top')).eql('5.599999904632568px')
Expand Down
8 changes: 0 additions & 8 deletions test/acceptance/safari/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,6 @@ test('Correct the inability to style clickable types in iOS and Safari.', async
.expect(Selector('[type="submit"][data-test--forms-1]').getStyleProperty('-webkit-appearance')).notEql('button');
});

test('Remove the inner border and padding in Firefox.', async t => {
// `-moz-focus-inner` does not exist in Safari
});

test('Restore the focus styles unset by the previous rule.', async t => {
// `-moz-focusring` does not exist in Safari
});

test('Correct the padding in Firefox.', async t => {
await t
.expect(Selector('fieldset[data-test--forms-2]').getStyleProperty('padding-top')).eql('5.599999904632568px')
Expand Down

0 comments on commit b3b9630

Please sign in to comment.