Add 'whole songbook' page #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This page will be the eventual menchanism of downloading and printing the songbook. For now it's added as an additional page that people can store offline or print to a PDF
It seems wrong to have the whole page songbook in the top nav, as it's not really the way we want people to use the site, and it's confusing about whether that's the 'songbook' or the 'songs' page is. This removes it from the nav and adds it to the 'songs' page an an option Also update the text about how to search from the two index pages
|
This is annoying without having the index at the top of the page link to songs on the page |
|
(This still isn't good for merging, but I think it would still be useful, so anyone is welcome to take a look at improving it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page will be the eventual menchanism of downloading and printing
the songbook. For now it's added as an additional page that people can
store offline or print to a PDF