Improve insights error message (#20)

* version bump

* more descriptive error message

* update pylint config

circle.yml

@@ -8,4 +8,4 @@ dependencies:
 
 test:
   post:
-    - pylint tap_facebook -d missing-docstring,too-few-public-methods,too-many-arguments,locally-disabled
+    - pylint tap_facebook -d C,R,W

setup.py

@@ -3,7 +3,7 @@
 from setuptools import setup
 
 setup(name='tap-facebook',
-      version='1.0.3',
+      version='1.0.4',
       description='Singer.io tap for extracting data from the Facebook Ads API',
       author='Stitch',
       url='https://singer.io',

tap_facebook/__init__.py

@@ -278,9 +278,11 @@ def run_job(self, params):
                     'Insights job {} did not start after {} seconds'.format(
                         job_id, INSIGHTS_MAX_WAIT_TO_START_SECONDS))
             elif duration > INSIGHTS_MAX_WAIT_TO_FINISH_SECONDS and status != "Job Completed":
-                raise Exception(
-                    'Insights job {} did not complete after {} seconds'.format(
-                        job_id, INSIGHTS_MAX_WAIT_TO_FINISH_SECONDS))
+                pretty_error_message = ('Insights job {} did not complete after {} minutes. ' +
+                    'This is an intermittent error and may resolve itself on subsequent queries to the Facebook API. ' +
+                    'You should deselect fields from the schema that are not necessary, ' +
+                    'as that may help improve the reliability of the Facebook API.')
+                raise Exception(pretty_error_message.format(job_id, INSIGHTS_MAX_WAIT_TO_FINISH_SECONDS//60))
             LOGGER.info("sleeping for %d seconds until job is done", sleep_time)
             time.sleep(sleep_time)
             if sleep_time < INSIGHTS_MAX_ASYNC_SLEEP_SECONDS: