Merge branch 'master' into qa/table-reset

singer-io · Aug 17, 2023 · 91cdcbe · 91cdcbe
2 parents e42a78d + 9761160
commit 91cdcbe
Show file tree

Hide file tree

Showing 9 changed files with 22 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## 1.19.0
+  * Add conversions to insights streams [#204](https://github.com/singer-io/tap-facebook/pull/204)
+
 ## 1.18.6
   * Bump facebook_business SDK to v17.0.2 for token param bug fix [#219](https://github.com/singer-io/tap-facebook/pull/219)
 

diff --git a/setup.py b/setup.py
@@ -3,7 +3,7 @@
 from setuptools import setup
 
 setup(name='tap-facebook',
-      version='1.18.6',
+      version='1.19.0',
       description='Singer.io tap for extracting data from the Facebook Ads API',
       author='Stitch',
       url='https://singer.io',

diff --git a/tap_facebook/insights_experiment.py b/tap_facebook/insights_experiment.py
@@ -33,6 +33,8 @@
     "canvas_avg_view_time",
     "clicks",
     "conversion_rate_ranking",
+    "conversion_values",
+    "conversions",
     "cost_per_action_type",
     "cost_per_inline_link_click",
     "cost_per_inline_post_engagement",
@@ -94,6 +96,8 @@
     "canvas_avg_view_time",
     "clicks",
     "conversion_rate_ranking",
+    "conversion_values",
+    "conversions",
     "cost_per_inline_link_click",
     "cost_per_inline_post_engagement",
     "cost_per_total_action",
@@ -190,6 +194,8 @@
     "campaign_name",
     "clicks",
     "conversion_rate_ranking",
+    "conversion_values",
+    "conversions",
     "date_start",
     "date_stop",
     "deeplink_clicks",

diff --git a/tap_facebook/schemas/ads_insights.json b/tap_facebook/schemas/ads_insights.json
@@ -7,6 +7,8 @@
     "unique_actions": {"$ref": "ads_action_stats.json"},
     "actions": {"$ref": "ads_action_stats.json"},
     "action_values": {"$ref": "ads_action_stats.json"},
+    "conversion_values": {"$ref": "ads_action_stats.json"},
+    "conversions": {"$ref": "ads_action_stats.json"},
     "outbound_clicks": {"$ref": "ads_action_stats.json"},
     "unique_outbound_clicks": {"$ref": "ads_action_stats.json"},
     "video_30_sec_watched_actions": {"$ref": "ads_action_stats.json"},
@@ -262,12 +264,6 @@
         "number"
       ]
     },
-    "reach": {
-      "type": [
-        "null",
-        "integer"
-      ]
-    },
     "canvas_avg_view_percent": {
       "type": [
         "null",

diff --git a/tap_facebook/schemas/ads_insights_age_and_gender.json b/tap_facebook/schemas/ads_insights_age_and_gender.json
@@ -8,6 +8,8 @@
     "actions": {"$ref": "ads_action_stats.json"},
     "action_values": {"$ref": "ads_action_stats.json"},
     "outbound_clicks": {"$ref": "ads_action_stats.json"},
+    "conversion_values": {"$ref": "ads_action_stats.json"},
+    "conversions": {"$ref": "ads_action_stats.json"},
     "unique_outbound_clicks": {"$ref": "ads_action_stats.json"},
     "video_30_sec_watched_actions": {"$ref": "ads_action_stats.json"},
     "video_p25_watched_actions": {"$ref": "ads_action_stats.json"},

diff --git a/tap_facebook/schemas/ads_insights_country.json b/tap_facebook/schemas/ads_insights_country.json
@@ -8,6 +8,8 @@
     "actions": {"$ref": "ads_action_stats.json"},
     "action_values": {"$ref": "ads_action_stats.json"},
     "outbound_clicks": {"$ref": "ads_action_stats.json"},
+    "conversion_values": {"$ref": "ads_action_stats.json"},
+    "conversions": {"$ref": "ads_action_stats.json"},
     "unique_outbound_clicks": {"$ref": "ads_action_stats.json"},
     "video_30_sec_watched_actions": {"$ref": "ads_action_stats.json"},
     "video_p25_watched_actions": {"$ref": "ads_action_stats.json"},

diff --git a/tap_facebook/schemas/ads_insights_dma.json b/tap_facebook/schemas/ads_insights_dma.json
@@ -5,6 +5,8 @@
     "actions": { "$ref": "ads_action_stats.json" },
     "action_values": { "$ref": "ads_action_stats.json" },
     "outbound_clicks": { "$ref": "ads_action_stats.json" },
+    "conversion_values": {"$ref": "ads_action_stats.json"},
+    "conversions": {"$ref": "ads_action_stats.json"},
     "unique_outbound_clicks": {"$ref": "ads_action_stats.json"},
     "video_30_sec_watched_actions": { "$ref": "ads_action_stats.json" },
     "video_p25_watched_actions": { "$ref": "ads_action_stats.json" },

diff --git a/tap_facebook/schemas/ads_insights_platform_and_device.json b/tap_facebook/schemas/ads_insights_platform_and_device.json
@@ -8,6 +8,8 @@
     "actions": {"$ref": "ads_action_stats.json"},
     "action_values": {"$ref": "ads_action_stats.json"},
     "outbound_clicks": {"$ref": "ads_action_stats.json"},
+    "conversion_values": {"$ref": "ads_action_stats.json"},
+    "conversions": {"$ref": "ads_action_stats.json"},
     "unique_outbound_clicks": {"$ref": "ads_action_stats.json"},
     "video_30_sec_watched_actions": {"$ref": "ads_action_stats.json"},
     "video_p25_watched_actions": {"$ref": "ads_action_stats.json"},

diff --git a/tap_facebook/schemas/ads_insights_region.json b/tap_facebook/schemas/ads_insights_region.json
@@ -8,6 +8,8 @@
     "actions": {"$ref": "ads_action_stats.json"},
     "action_values": {"$ref": "ads_action_stats.json"},
     "outbound_clicks": {"$ref": "ads_action_stats.json"},
+    "conversion_values": {"$ref": "ads_action_stats.json"},
+    "conversions": {"$ref": "ads_action_stats.json"},
     "unique_outbound_clicks": {"$ref": "ads_action_stats.json"},
     "video_30_sec_watched_actions": {"$ref": "ads_action_stats.json"},
     "video_p25_watched_actions": {"$ref": "ads_action_stats.json"},