Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for summary param error - Added retry logic #239

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

sgandhi1311
Copy link
Member

@sgandhi1311 sgandhi1311 commented Apr 15, 2024

Description of change

Few connections are getting below error -

2024-02-26 14:36:21,288Z    tap -   Status:  400
2024-02-26 14:36:21,288Z    tap -   Response:
2024-02-26 14:36:21,288Z    tap -     {
2024-02-26 14:36:21,289Z    tap -       "error": {
2024-02-26 14:36:21,289Z    tap -         "message": "(#100) Cannot include cost_per_inline_post_engagement, unique_inline_link_click_ctr, frequency, video_play_curve_actions, unique_ctr, ctr, spend, unique_clicks, unique_inline_link_clicks, video_p100_watched_actions, campaign_name in summary param because they weren't there while creating the report run. All available values are: ",
2024-02-26 14:36:21,289Z    tap -         "type": "OAuthException",
2024-02-26 14:36:21,289Z    tap -         "code": 100,
2024-02-26 14:36:21,289Z    tap -         "fbtrace_id": "*************"
2024-02-26 14:36:21,289Z    tap -       }
2024-02-26 14:36:21,289Z    tap -     }

Upon investigation, we discovered that this error originates from Facebook's end. While awaiting a fix from Facebook, we've implemented a workaround on the tap side. We've added retry logic for the aforementioned error message, allowing successful data retrieval upon retrying the request.

Manual QA steps

  • Perform a PR alpha on the affected connections.
  • Verify that the retry logic successfully handles the error and fetches the data as expected.

Risks

  • The workaround relies on retry logic; while effective, it's essential to monitor any potential issues that may arise due to the temporary nature of this fix.

Rollback steps

  • revert this branch

@sgandhi1311 sgandhi1311 changed the title Tdl 25115 fix summary param error Fix for summary param error - Added retry logic Apr 15, 2024
@Vi6hal Vi6hal self-requested a review April 15, 2024 11:55
@sgandhi1311 sgandhi1311 merged commit 534bded into master Apr 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants