-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded User Docs - WIP (Feedback Requested) #36
base: master
Are you sure you want to change the base?
Expanded User Docs - WIP (Feedback Requested) #36
Conversation
Hi @aaronsteers, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Adding some TODO items based on the TK / TODO entries:
|
Update: Successfully tested installation and execution on Windows with JRE only (not JDK). Resolving checkbox 5 above. |
You did it @aaronsteers! Thank you for signing the Singer Contribution License Agreement. |
To any active code maintainers, I could use guidance on item #s above: Thanks! |
I also intend to take a stab at the Dockerfile and docker image - although I can host+manage that Dockerfile elsewhere if you'd rather not add more to maintain here. UPDATE: Completed |
Description of change
As a new user and someone completely unfamiliar with Clojure, I struggled to get started on this tap. @dmosorast has been very helpful in slack and I thought I would try to contribute back to the docs at the same time as I am getting this setup for myself.
QA steps
TK
(why TK?) orTODO:
before merging.Risks
docs
folder. I have tried to be very careful to not remove any content, while still cleaning up and simplifying the mainREADME.md
file.java
as the path instead of a hardcoded java path. If this breaks anyone else, we may need to revert. Ideally, I think we would check first forJAVA_HOME
and then fallback tojava
if it's on the path.Rollback steps