Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded User Docs - WIP (Feedback Requested) #36

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

aaronsteers
Copy link

Description of change

As a new user and someone completely unfamiliar with Clojure, I struggled to get started on this tap. @dmosorast has been very helpful in slack and I thought I would try to contribute back to the docs at the same time as I am getting this setup for myself.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
  • Search and resolve any references to TK (why TK?) or TODO: before merging.

Risks

  • Minimal risk. Most/all changes are documentation-related, creating dedicated markdown docs in a new docs folder. I have tried to be very careful to not remove any content, while still cleaning up and simplifying the main README.md file.
  • For my purposes, I seemed to be able to test using simply java as the path instead of a hardcoded java path. If this breaks anyone else, we may need to revert. Ideally, I think we would check first for JAVA_HOME and then fallback to java if it's on the path.

Rollback steps

  • revert this branch

@cmerrick
Copy link

cmerrick commented Jun 6, 2020

Hi @aaronsteers, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@aaronsteers
Copy link
Author

aaronsteers commented Jun 6, 2020

Adding some TODO items based on the TK / TODO entries:

  • 1 - /README.md: Recommend a docker image for docker-based execution instructions:
    • Create Dockerfile (ideally at root of repo) or reference one from another source repo.
    • Publish the docker image
    • Automate docker image maintenance
  • 2 - /docs/config.md: Add instructions for log-based replication. (I don't know how this is configured yet.)
  • 3 - /docs/config.md: Confirm whether there are any settings still missing.
  • 4 - docs/CONTRIBUTING.md: Optionally, add guidelines/instructions for contributors to this default path, or delete file if not needed.
  • 5 - /docs/installation.md: Confirm JRE works for runtime-only environments (not developing or compiling).
  • 6 - docs/installation.md: Add any specific prerequisites or workstation config steps for developers/testers (if applicable).

@aaronsteers
Copy link
Author

Update: Successfully tested installation and execution on Windows with JRE only (not JDK). Resolving checkbox 5 above.

@cmerrick
Copy link

cmerrick commented Jun 6, 2020

You did it @aaronsteers!

Thank you for signing the Singer Contribution License Agreement.

@aaronsteers
Copy link
Author

To any active code maintainers, I could use guidance on item #s above: 2 (how does log-based replication get configured?) and 3 (am I'm missing any config options in docs/config.md?).

Thanks!

@aaronsteers
Copy link
Author

aaronsteers commented Jun 6, 2020

I also intend to take a stab at the Dockerfile and docker image - although I can host+manage that Dockerfile elsewhere if you'd rather not add more to maintain here.

UPDATE: Completed Dockerfile, ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants