Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding change replication test #78

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

adding change replication test #78

wants to merge 7 commits into from

Conversation

manand31
Copy link
Contributor

Description of change

Added a test to validate the replication change scenario

QA steps

  • execute test_change_replication.py

Risks

Rollback steps

  • revert this branch

@manand31 manand31 requested a review from kspeer825 June 29, 2022 17:59
kspeer825
kspeer825 suggested changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@kspeer825 kspeer825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 very minor comment. Also the regression run failed.

tests/test_change_replication.py Outdated Show resolved Hide resolved
@manand31 manand31 added the testing QA work. No src code changes. label Jul 5, 2022
@manand31 manand31 requested a review from kspeer825 July 5, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kspeer825 kspeer825 kspeer825 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
testing QA work. No src code changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manand31 @kspeer825