fix(deps): upgrade PyMySQL to v1.1.1 to resolve connection reset bug #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ro0tkid00, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @ro0tkid00! Thank you for signing the Singer Contribution License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR upgrades the PyMySQL dependency to v1.1.1 to resolve an issue where connections reset during database operations caused a
NoneTypeerror due to the connection being closed unexpectedly. This issue was fixed in PyMySQL commit bd3bd014. The bug manifested as anAttributeError: 'NoneType' object has no attribute 'settimeout'when the connection was reset during an operation.QA steps
Risks
Major version upgrade of PyMySQL: Could introduce breaking changes in tap-mysql. The backward-incompatible changes (e.g., positional arguments in connect()) have been audited and handled, but there is still a risk of issues if there are any unhandled edge cases.
Older MySQL versions: MySQL 5.5 is no longer officially supported by PyMySQL, so users running this version may encounter problems.
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code