-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add enabled_departments #27
add enabled_departments #27
Conversation
Hi @jakedave, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
You did it @jakedave! Thank you for signing the Singer Contribution License Agreement. |
Any idea when this will be reviewed and merged? |
Hi @cmerrick Hope this can be merged soon. We are affected with this issue as well and it's blocked all replication |
@SeanFLynch @rushi I tried reaching out to the repo's maintainers via email. This repo hasn't been maintained in years though, I'm not optimistic my PR (or any at all) will be merged. |
I am in favor of this commit. But just an idea to work yourself around this issue until this is merged: I've published my version of the singer tap here #28 which implements singer transform before writing the records to the target. When you don't have a need for this property, my version of this tap will clear out the property so you should not get any issues anymore. |
I use StitchData to sync data from Zendesk to Google BigQuery. Ideally I would want @jakedave's change, but I don't think Stitch has a method to add a custom integration of my own. Otherwise I would just get Jake's changes, compile and use that. @cmerrick Anyway we can use these changes without waiting it to be merged upstream? |
@rushi You might be able to push StichData to merge it via the Singer Slack channel: https://singer-slackin.herokuapp.com/ |
Description of change
Adds
enabled_departments
as a non-mandatory arraysource
References issue: #26
Manual QA steps
Risks
Rollback steps