Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enabled_departments #27

Merged
merged 1 commit into from
Apr 16, 2021
Merged

add enabled_departments #27

merged 1 commit into from
Apr 16, 2021

Conversation

jakedave
Copy link
Contributor

@jakedave jakedave commented Apr 7, 2021

Description of change

Adds enabled_departments as a non-mandatory array

source

References issue: #26

Manual QA steps

Risks

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

cmerrick commented Apr 7, 2021

Hi @jakedave, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

cmerrick commented Apr 7, 2021

You did it @jakedave!

Thank you for signing the Singer Contribution License Agreement.

@SeanFLynch
Copy link

Any idea when this will be reviewed and merged?

@rushi
Copy link

rushi commented Apr 11, 2021

Hi @cmerrick Hope this can be merged soon. We are affected with this issue as well and it's blocked all replication

@jakedave
Copy link
Contributor Author

@SeanFLynch @rushi I tried reaching out to the repo's maintainers via email. This repo hasn't been maintained in years though, I'm not optimistic my PR (or any at all) will be merged.

@ghost
Copy link

ghost commented Apr 13, 2021

I am in favor of this commit. But just an idea to work yourself around this issue until this is merged:

I've published my version of the singer tap here #28 which implements singer transform before writing the records to the target. When you don't have a need for this property, my version of this tap will clear out the property so you should not get any issues anymore.

@rushi
Copy link

rushi commented Apr 13, 2021

I use StitchData to sync data from Zendesk to Google BigQuery. Ideally I would want @jakedave's change, but I don't think Stitch has a method to add a custom integration of my own. Otherwise I would just get Jake's changes, compile and use that.

@cmerrick Anyway we can use these changes without waiting it to be merged upstream?

@ghost
Copy link

ghost commented Apr 13, 2021

@rushi You might be able to push StichData to merge it via the Singer Slack channel: https://singer-slackin.herokuapp.com/
Or you create a supprt request for them

@KAllan357 KAllan357 merged commit 6822981 into singer-io:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants