Added comments in the code. #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/unittests/test_http.py
Outdated
| self.assertDictEqual({"key1": "val1", **PAGINATE_RESPONSE}, | ||
| responses[0]) | ||
| #Verifi response of 2nd call has expected SINGLE_RESPONSE |
There was a problem hiding this comment.
It should be # Verify response of 2nd call has expected SINGLE_RESPONSE
tap_zendesk/__init__.py
Outdated
| for stream in catalog.streams: | ||
| stream_name = stream.tap_stream_id | ||
| mdata = metadata.to_map(stream.metadata) | ||
| #If stream does not selected then skip it. |
There was a problem hiding this comment.
Suggested change
| #If stream does not selected then skip it. | |
| # If the stream is not selected then skip it. |
tap_zendesk/streams.py
Outdated
| @@ -245,6 +259,7 @@ def sync(self, state): | |||
|
|
|||
| # Assumes that the for loop got everything | |||
| singer.write_state(state) | |||
| #If search_window_size less or equall than half of original window size then make it double. | |||
There was a problem hiding this comment.
Suggested change
| #If search_window_size less or equall than half of original window size then make it double. | |
| # If search_window_size is less or equal to half of the original window size, then make it double. |
test/unittests/test_http.py
Outdated
| @@ -38,11 +38,13 @@ def test_get_cursor_based_gets_one_page(self, mock_get): | |||
| responses = [response for response in http.get_cursor_based(url='some_url', | |||
| access_token='some_token')] | |||
| actual_response = responses[0] | |||
| #Verify actual response of cursor based gets is equall to SINGLE_RESPONSE | |||
There was a problem hiding this comment.
Suggested change
| #Verify actual response of cursor based gets is equall to SINGLE_RESPONSE | |
| # Verify actual response of cursor-based gets is equal to SINGLE_RESPONSE |
dbshah1212
approved these changes
Nov 1, 2021
karanpanchal-crest
approved these changes
Nov 1, 2021
umangagrawal-crest
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added comments in the code.
Manual QA steps
Risks
Rollback steps