TDL-15454 removed the buffer system #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namrata270998
changed the title
dbshah1212
reviewed
Oct 18, 2021
test/unittests/test_yield_records.py
Outdated
| @mock.patch('tap_zendesk.streams.TicketMetrics.sync') | ||
| @mock.patch('tap_zendesk.streams.TicketComments.sync') | ||
| @mock.patch('tap_zendesk.streams.CursorBasedExportStream.get_objects') | ||
| def test_yield_records(mock_objects, mock_comments_sync, mock_metrics_sync, mock_audits_sync, mock_comments, mock_metrics, mock_audits, mock_get_bookmark, mock_update_bookmark): |
There was a problem hiding this comment.
Please add comments in unit test
dbshah1212
reviewed
Oct 27, 2021
| @@ -308,12 +275,12 @@ def emit_sub_stream_metrics(sub_stream): | |||
| self.update_bookmark(state, utils.strftime(generated_timestamp_dt)) | |||
|
|
|||
| ticket.pop('fields') # NB: Fields is a duplicate of custom_fields, remove before emitting | |||
| should_yield = self._buffer_record((self.stream, ticket)) | |||
| yield (self.stream, ticket) | |||
There was a problem hiding this comment.
Any reason for yielding self.stream? instead of just ticket
There was a problem hiding this comment.
because the buffer_records also had self.stream passed as an argument. And it helps in identifying which stream is yielded.
There was a problem hiding this comment.
Yes because earlier it is required to identify the stream in function _buffer_record as there is login on the stream name, I don't see that logic now, do we still need this?
There was a problem hiding this comment.
added a comment regarding why we are yielding stream name and rec in the code
….com/singer-io/tap-zendesk into TDL-15454-remove-buffer-from-tickets
karanpanchal-crest
approved these changes
Nov 1, 2021
KrisPersonal
requested changes
Nov 2, 2021
KrisPersonal
approved these changes
Nov 8, 2021
* API call to the each stream in discovery mode done * removed generated catalog file * resolved pylint errors * Resolved cyclic import pylint error * Improved unittest case civerage * Updated error message for 403 forbidden error * Updated error handling * resolved pylint error * Removed empty catalog * Removed unused catalog file. * Removed unused state file * Removed unused state file * Removed unused file * Updated error message and unittest case for 404 error * Updated check access method * Resolved pylint error * recolved unused argument error * resolved kwargs error * Updated unittest cases * Updated unittest cases * Removed global variable * Improved unittest case coverage * updated 404 error * resolved pylint error * Updated typo error. * Removed f strings * Updated error handling * resloved pylint error * resolved unittest case error * Added more comments and updated code * resolved pylint error * updated method name * Added timeout error code * Resolved pylint error * added coverage report to artifact * added pylint back * Added comment * resolved pylint errors * Enhanced the code * Reutilized args0 * Moved request_timeout parameter to common class * Added comment * Removed static time * removed warning message * resolved pylint error * resolved the comments Co-authored-by: namrata270998 <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps