Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validation optional #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make validation optional #25

wants to merge 3 commits into from

Conversation

petedannemann
Copy link

@petedannemann petedannemann commented Dec 11, 2019

Description of change

Make validation optionally configurable. This attempts to solve #24

Manual QA steps

  • Clone this PR
  • pip install -e .
  • create a config file with validate_records
{
    "validate_records": false
}
  • Run on a mysql database with validation
  • Run validate_records above to True
  • Run on a mysql database with validation

Risks

  • None

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

Hi @petedannemann, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @petedannemann!

Thank you for signing the Singer Contribution License Agreement.

fertek added a commit to fertek/target-csv that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants