Skip to content

Commit

Permalink
Remove unused dependencies (#107)
Browse files Browse the repository at this point in the history
* Remove unused dependencies, make pylint happy

* update pylint
  • Loading branch information
leslievandemark authored Jan 11, 2024
1 parent 62c2698 commit 2498846
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ jobs:
nosetests -v tests/activate_version_tests.py
nosetests -v --ignore-files=activate_version_tests.py
#nosetests
pylint target_stitch "--extension-pkg-whitelist=ciso8601" -d global-variable-not-assigned
pylint target_stitch "--extension-pkg-whitelist=ciso8601" -d 'global-variable-not-assigned, consider-using-generator, broad-exception-raised, unused-argument'
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 3.2.2
* Remove unused dependencies [#107](https://github.com/singer-io/target-stitch/pull/107)

## 3.2.1
* Updated dependencies to support Python 3.9.6, deprecated support for Python 3.5.X. [#104](https://github.com/singer-io/target-stitch/pull/104)

Expand Down
4 changes: 1 addition & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup

setup(name='target-stitch',
version='3.2.1',
version='3.2.2',
description='Singer.io target for the Stitch API',
author='Stitch',
url='https://singer.io',
Expand All @@ -17,8 +17,6 @@
'psutil==5.6.6',
'simplejson==3.11.1',
'aiohttp==3.7.4',
'cchardet==2.1.7',
'aiodns==2.0.0',
'ciso8601',
],
extras_require={
Expand Down
4 changes: 1 addition & 3 deletions target_stitch/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,6 @@ def __init__(self, output_file, max_batch_bytes, max_batch_records):
self.max_batch_bytes = max_batch_bytes
self.max_batch_records = max_batch_records

# pylint: disable=R0201
def handle_state_only(self, state_writer=None, state=None):
LOGGER.info("LoggingHandler handle_state_only: %s", state)
if state:
Expand Down Expand Up @@ -393,15 +392,14 @@ class ValidatingHandler: # pylint: disable=too-few-public-methods
def __init__(self):
getcontext().prec = 76

# pylint: disable=R0201
def handle_state_only(self, state_writer=None, state=None):
LOGGER.info("ValidatingHandler handle_state_only: %s", state)
if state:
line = simplejson.dumps(state)
state_writer.write(f"{line}\n")
state_writer.flush()

def handle_batch(self, messages, contains_activate_version, schema, key_names, bookmark_names=None, state_writer=None, state=None): # pylint: disable=no-self-use,unused-argument
def handle_batch(self, messages, contains_activate_version, schema, key_names, bookmark_names=None, state_writer=None, state=None):
'''Handles messages by validating them against schema.'''
LOGGER.info("ValidatingHandler handle_batch")
validator = Draft4Validator(schema, format_checker=FormatChecker())
Expand Down

0 comments on commit 2498846

Please sign in to comment.