Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB] Fix: removed unicode from QuillText element that causes weird caret behavior #2453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CatHood0
Copy link
Collaborator

@CatHood0 CatHood0 commented Jan 27, 2025

Description

Fixed a bug where trying to position the cursor on a completely empty line would not position it correctly. This was due to the use of a \u200b character which caused the same error. Removing it will solve the problem.

Question: ¿Why was that unicode there?

Knowing the reason, i can test better if the change does not break a part of the editor.

I put a red background color to the text lines to represent better the issue.

With the unicode

with_unicode-2025-01-27_19.14.49.mp4

Without the unicode

without_unicode-2025-01-27_19.16.06.mp4

Related Issues

Type change

  • Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Build/configuration changes.

TODO:

  • test if this change does not break something.

@CatHood0 CatHood0 added the bug Something isn't working label Jan 27, 2025
@CatHood0 CatHood0 self-assigned this Jan 27, 2025
@CatHood0 CatHood0 marked this pull request as draft January 27, 2025 23:28
@CatHood0 CatHood0 changed the title Fix: removed unicode from QuillText element that causes weird caret behavior [WEB] Fix: removed unicode from QuillText element that causes weird caret behavior Jan 29, 2025
@CatHood0 CatHood0 marked this pull request as ready for review January 31, 2025 16:41
Copy link
Collaborator

@EchoEllet EchoEllet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not much I can review here as I'm unfamiliar with the topic however LGTM.

@CatHood0 Please modify CHANGELOG.md to document this change, all changes must be documented so clients aware of them and we can track regressions easier through versions.

It doesn't have to be perfect or consistent, if it's in the changed files, I can modify the file directly from GitHub UI for future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem when clicking on empty spaces in flutter web
3 participants