-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r] Update DESCRIPTION
to 1.5.1
#1903
Conversation
Should we sweep up more PRs (and #1894 is a candidate though not a must have) and/or wait for an updated-at-CRAN SeuratObject, or is your preference to get this out ASAP? |
@eddelbuettel The cross-organizational discussion last week was to tag 1.5.1 today, while @mojaveazure says he should have the Seurat issue solved later this week. (See also https://github.com/TileDB-Inc/TileDB-Cloud-JupyterHub/pull/562/commits/b01ce792788538cb3fd083d7624c1bbf9ac9ce97.) That would place #1894 beyond 1.5.1. |
@eddelbuettel I don't mind getting #1894 in but it needs to be accepted and merged to |
Yes #1894 should either get accepted (looking at eg you among three possible reviewers, can't do it myself) or get closed. It was a 50% hail mary on the issue created by Matrix/SeuratObject having a fight, ended up not hurting us, but it would be marginally better to test under 4.3.2 anyway. So for general PR hygiene we should either accept or close. Your assistance in that resolution would be appreciated. I'll accept this one to let you proceed the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eddelbuettel I wasn't a reviewer on #1894 but I'll self-add, given your suggestion. Thanks! |
I see. Thanks for unblocking. |
Co-authored-by: John Kerl <[email protected]>
This is a small bugfix release