Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Use schema from tiledb::Array instead of ManagedQuery #3277

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Nov 1, 2024

Issue and/or context:

As part of work for #3053.

Changes:

This introduces a schema_ field to the SOMAArray, replacing any mq->schema() calls with schema_ directly.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (bf62847) to head (03befff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3277      +/-   ##
==========================================
+ Coverage   83.67%   83.78%   +0.10%     
==========================================
  Files          51       51              
  Lines        5556     5556              
==========================================
+ Hits         4649     4655       +6     
+ Misses        907      901       -6     
Flag Coverage Δ
python 83.78% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.78% <ø> (+0.10%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@nguyenv nguyenv requested a review from johnkerl November 1, 2024 20:25
@nguyenv nguyenv force-pushed the use-array-schema-directly branch from a543b75 to f7a8df3 Compare November 1, 2024 20:28
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💫

@nguyenv nguyenv merged commit 13a40b5 into main Nov 1, 2024
15 checks passed
@nguyenv nguyenv deleted the use-array-schema-directly branch November 1, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants