[c++/python] SOMAGeometryDataFrame basic write
#3687
+695
−247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oordinate space objects
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3687 +/- ##
==========================================
+ Coverage 86.31% 86.37% +0.06%
==========================================
Files 55 55
Lines 6495 6524 +29
==========================================
+ Hits 5606 5635 +29
Misses 889 889
Flags with carried forward coverage won't be shown. Click here to find out more.
|
XanthosXanthopoulos
changed the title
SOMAGeometryDataFrame basic write [WIP]SOMAGeometryDataFrame basic write
XanthosXanthopoulos
requested review from
johnkerl,
jp-dark and
nguyenv
and removed request for
johnkerl and
jp-dark
jp-dark
approved these changes
Feb 13, 2025
johnkerl
reviewed
Feb 13, 2025
| @@ -311,6 +314,17 @@ def __init__( | |||
|
|
|||
| # Data operations | |||
|
|
|||
| def __len__(self) -> int: | |||
There was a problem hiding this comment.
This is very convenient! But (AFAIK) not implemented for the other dataframe classes.
Might be worth doing for the other dataframe classes (as a separate PR).
johnkerl
requested changes
Feb 13, 2025
| return self | ||
|
|
||
| # Write helpers with automatic transformations | ||
| def from_outlines( |
There was a problem hiding this comment.
Should I know what an 'outline' is?
| @@ -0,0 +1,87 @@ | |||
| /** | |||
| * @file managed_query.cc | |||
| * | ||
| * @section DESCRIPTION | ||
| * | ||
| * This file defines the ManagedQuery bindings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
Changes:
Notes for Reviewer:
This PR moves the helper methods transforming from polygon outlines to WKB encoded geometry into a separate class. Adds a basic transformer pipeline and exposes it to the python API and adds helper methods to the python API for ingesting with a transformation.
The C++
GeometryDataFramecleanup will happen after updating all read and write operations withManagedQuery