Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Add option to link installed spdlog lib #3698

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XanthosXanthopoulos
Copy link
Collaborator

@XanthosXanthopoulos XanthosXanthopoulos commented Feb 13, 2025

Issue and/or context: #3585 #3154 [sc-57301]

Changes:

Notes for Reviewer:

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (bd6b6cd) to head (1ff45c9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3698       +/-   ##
===========================================
+ Coverage   65.53%   86.35%   +20.81%     
===========================================
  Files         151       55       -96     
  Lines       19427     6494    -12933     
  Branches     1164        0     -1164     
===========================================
- Hits        12732     5608     -7124     
+ Misses       6292      886     -5406     
+ Partials      403        0      -403     
Flag Coverage Δ
libtiledbsoma ?
python 86.35% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.35% <ø> (+0.03%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Collaborator

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdblischak
Copy link
Collaborator

I am testing SPDLOG_LINK_SHARED=ON in my feedstock fork:

I still got the same linking WARNING from conda-build after setting SPDLOG_LINK_SHARED=ON:

jdblischak/tiledbsoma-feedstock@3b7e6ff

WARNING (libtiledbsoma): run-exports library package conda-forge/linux-64::fmt==11.0.2=h434a139_0 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
WARNING (libtiledbsoma): run-exports library package conda-forge/linux-64::spdlog==1.15.1=hb29a8c4_0 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants