Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to output native modules. Add outputSystemJS option. #412

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

joeldenning
Copy link
Member

This is a breaking change that changes all create-single-spa projects to default to outputting native ES modules.

Copy link
Contributor

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As-is this seems correct. For Webpack, don't we also need to ensure "type": "module" is set in package.json?

@joeldenning
Copy link
Member Author

For Webpack, don't we also need to ensure "type": "module" is set in package.json?

My understanding (might be incomplete) is that "type": "module" in the package.json is needed for webpack to know what kinds of source files it is dealing with, not the output format. I tested this change locally and webpack compiled without issue.

@ibacher
Copy link
Contributor

ibacher commented Sep 30, 2024

Perfect! Seems that my approvals are meaningless to GitHub, but that's fine with me.

@joeldenning joeldenning merged commit f9edeef into main Sep 30, 2024
1 check passed
@joeldenning joeldenning deleted the native-modules branch September 30, 2024 21:36
@joeldenning
Copy link
Member Author

joeldenning commented Oct 2, 2024

Seems that my approvals are meaningless to GitHub, but that's fine with me.

I removed all write access during the permissions re-do a couple weeks ago, which might be why? I'm opening to changing a setting to make the approval checkmark green instead of gray, if it's possible without granting write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants