Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Update contract api #1818

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

[FIX] Update contract api #1818

wants to merge 8 commits into from

Conversation

pls-github-dont-suspend-me
Copy link
Collaborator

@pls-github-dont-suspend-me pls-github-dont-suspend-me commented Jun 4, 2024 •
edited
Loading

This pull request focuses on updating the contract-api service and the common section code.

The main objectives of this PR are outlined below:

  1. Project Structure Improvement: Reorganize the project into three distinct layers: domain, infrastructure, and application for better clarity.
  2. Request Schemas: Introduce Pydantic schemas for incoming requests to ensure data validation and improve code readability.
  3. Entity Model Update: Refactor entity models using dataclasses with the frozen parameter to enhance immutability.
  4. SQLAlchemy Update: Transition from raw SQL code to the new SQLAlchemy syntax for improved maintainability and performance.
  5. Pagination Enhancement: Fix and add pagination to methods for retrieving services and organizations to enhance usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pls-github-dont-suspend-me @Deralden