-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Dark/light mode functionality #131
Added the Dark/light mode functionality #131
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Why are you creating another PR ? @ChaithanyaKrishna28. You have an existing one right ? #111. Seems like the old one have conflicts, so I'm closing that. We can verify this new one. |
Sorry for making trouble making another pr. --thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Dark mode is still not applied for Canvas(Whiteboard) and stroke color.
In light mode, we have
We need the colors to be changed while toggling the theme, So we can have this pair of colors for Dark theme.
Additionally, please change the theme toggle button's bg during dark mode. We can't set the body background for the button also.
Notify me once you made these changes.
Ok I will notify once it's completed |
@0xabdulkhalid Can you please give some more detailed information. |
@ChaithanyaKrishna28, I already gave you the references on my Request part. You need to change the colors for dark mode, just make sure to follow them. |
@ChaithanyaKrishna28, We need the colors to be changed while toggling the theme, So we can have this pair of colors for Dark theme. You need to change the drawing board to darker color, and need to change the painting color to white and background of I gave you the color codes, make sure to apply them properly. |
@0xabdulkhalid
issues |
@ChaithanyaKrishna28, what you're saying is absolutely right. But you can try to change those things only if the user haven't drawn anything on the board(canvas). If the user drawn any things on board then you don't need to change the board and brush color. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Ready to be merged 🚀
Now can you merge the pull request. |
@0xabdulkhalid @singodiyashubham87 are good to go for merge !!! |
@ChaithanyaKrishna28 Well Done, Keep Contriubting : ) |
Thank you so much! I appreciate your encouragement and will definitely keep contributing. Your support means a lot! |
Issue Title:
resolve issue: #45
Type of change ☑️
What sort of change have you made:
New feature: This pull request introduces the implementation of a dark mode and light mode feature to enhance user experience and accessibility. Users will now have the option to toggle between different visual modes according to their preference. This addition is a non-breaking change, meaning it does not disrupt existing functionality but instead adds new functionality to the application.
Checklist: ☑️
How Has This Been Tested? ⚙️
Describe how have you verified the changes made.
I have deployed it in my local machine and on the web also.
I have used both light and dark mode settings to verify that the interface adapts seamlessly.
It work fine.
I have only used Tailwind css.
Here are some of the pictures
before feature:
After feature Light mode:
After feature Dark mode: