Change Application.isEditor
check order in InitializeSingularSDK
in editor
#15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.
Awake
andInitializeSingularSDK
initialization flow order in editorWhile initializing SingularSDK via
InitializeSingularSDK
in the Unity Editor I've encountered errorSingularSDK InitializeSingularSDK, no instance available - cannot initialize
.It seems like strange behavior to Me because this error occurs when there's no
SingularSDK
instance, however, it's impossible for the instance to exist because there's a check inAwake
before its creation to ensure, if We are in the editor, thenreturn
.So in My PR I've changed
Awake
to be more likeInitializeSingularSDK
: firstly check if We're in the editor and then - if We have an instance ofSingularSDK
Before fix:
if(Application.isEditor)
->if(instance)
if(!instance)
->if(Application.isEditor)
After fix:
if(Application.isEditor)
->if(instance)
if(Application.isEditor)
->if(!instance)
Commit
2.
Private
keywords, whitespaces and unused methodsAlso I've added
private
keywords to Unity methods and deleted some whitespaces + unusedUpdate
methodCommit 'whitespaces and unused methods'
Commit 'access keywords'