do not change instance name (#216)

* do not change instance name * pre-formating done * bump version to 0.3.13 * document changes Co-authored-by: Eric DEVEAUD <[email protected]>
singularityhub · Dec 12, 2023 · c207c3e · c207c3e
1 parent 29c7d36
commit c207c3e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@ The client here will eventually be released as "spython" (and eventually to
 singularity on pypi), and the versions here will coincide with these releases.
 
 ## [master](https://github.com/singularityhub/singularity-cli/tree/master)
+ - do not modify user provided instance name when generating new instance (0.3.13)
  - bug with instance.run_command (0.3.12)
  - added check to enbsure stderr exists upon a non-zero return code when streaming (0.3.11)
  - exposed the stream type option, and ability to capture both stdout and stderr when stream=True (0.3.1)

diff --git a/spython/instance/__init__.py b/spython/instance/__init__.py
@@ -47,7 +47,10 @@ def generate_name(self, name=None):
         # If no name provided, use robot name
         if name is None:
             name = self.RobotNamer.generate()
-        self.name = name.replace("-", "_")
+        # dash allowed in instance name.
+        # authorizedChars = `^[a-zA-Z0-9._-]+$` from instance_linux.go
+        # self.name = name.replace("-", "_")
+        self.name = name
 
     def parse_image_name(self, image):
         """

diff --git a/spython/version.py b/spython/version.py
@@ -5,7 +5,7 @@
 # with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 
-__version__ = "0.3.12"
+__version__ = "0.3.13"
 AUTHOR = "Vanessa Sochat"
 AUTHOR_EMAIL = "[email protected]"
 NAME = "spython"