test for stderr before printing #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very reasonable! Could you please bump the version in version.py and add a note in CHANGELOG.md? |
|
Ok, I think I have done this. |
vsoch
reviewed
Nov 23, 2023
spython/version.py
Outdated
| @@ -5,7 +5,7 @@ | |||
| # with this file, You can obtain one at http://mozilla.org/MPL/2.0/. | |||
|
|
|||
|
|
|||
| __version__ = "0.3.1" | |||
| __version__ = "0.3.2" | |||
There was a problem hiding this comment.
This should be 0.3.11
Not perfect semver, but allows for tiny changes like this one :)
vsoch
reviewed
Nov 23, 2023
CHANGELOG.md
Outdated
| @@ -17,6 +17,7 @@ The client here will eventually be released as "spython" (and eventually to | |||
| singularity on pypi), and the versions here will coincide with these releases. | |||
|
|
|||
| ## [master](https://github.com/singularityhub/singularity-cli/tree/master) | |||
| - added check to enbsure stderr exists upon a non-zero return code when streaming (0.3.2) | |||
There was a problem hiding this comment.
Suggested change
| - added check to enbsure stderr exists upon a non-zero return code when streaming (0.3.2) | |
| - added check to enbsure stderr exists upon a non-zero return code when streaming (0.3.11) |
There was a problem hiding this comment.
Ha, yes. Ok. Fixed this as well :P
vsoch
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, sometimes an error is raised when there is no
stderrattached to theprocessobject. This will test to ensure it does exist before trying to read from it.