Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condensers Ignore Covalence Loss #1982

Open
wants to merge 5 commits into
base: mc1.12.x
Choose a base branch
from
Open

Condensers Ignore Covalence Loss #1982

wants to merge 5 commits into from

Conversation

DBPhoenix
Copy link

Just leaving this hanging here, if you'll ever consider adding it.

@James103
Copy link

The one change you made is split into five separate commits, one for each file you touched. This is not ideal, as it bloats up the repository's commit history with unnecessary commits. Could you please consider squashing the commits together into one before merge?

@DBPhoenix
Copy link
Author

DBPhoenix commented May 30, 2020

Hi James103,

As I don't have anything stored locally anymore, it'd take quite some time for me to fix in the ways I'm aware of. As far as I know, there should be a way for repository managers to "Squash and merge" when merging?

Best regards,
DBPhoenix

@James103
Copy link

Yes, assuming you can merge pull requests and the repo allows squash merging, there is a way: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-request-merges#squash-and-merge-your-pull-request-commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants