Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdleDeadline feature #421

Closed
wants to merge 1 commit into from
Closed

Conversation

soferdani
Copy link
Contributor

Fix issue #358 create IdleDeadline functionality for the requestIdleCallback

Please have a look at the requestIdleCallback test section I comment out. I couldn't make this test work, and I think it's because the new feature open the callback and call it with the IdleDeadline object I created.

@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ead4842) 95.49% compared to head (48f1995) 95.37%.
Report is 77 commits behind head on main.

Files Patch % Lines
src/fake-timers-src.js 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
- Coverage   95.49%   95.37%   -0.12%     
==========================================
  Files           1        1              
  Lines         621      627       +6     
==========================================
+ Hits          593      598       +5     
- Misses         28       29       +1     
Flag Coverage Δ
unit 95.37% <92.85%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatso83
Copy link
Contributor

fatso83 commented Nov 22, 2022

Thanks for this. I did have a quick look, but I guess getting those stack traces right is non-trivial and I can't see exactly what it is to be done by a quick glance.

Copy link

stale bot commented Dec 27, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 27, 2023
@fatso83
Copy link
Contributor

fatso83 commented Feb 10, 2024

It's been two years and it has not moved much. I have no personal interest in this, so for this to go forward, someone needs to pick it up. I can't debug on something I really do not know anything about. Will close, but can reopen if someone picks it up!

@stale stale bot removed the stale label Feb 10, 2024
@fatso83 fatso83 closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants