Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove fakeXMLHttpRequest and fakeServer #2642

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mroderick
Copy link
Member

BREAKING CHANGE: remove fakeXMLHttpRequest and fakeServer from the API

Times have changed, and people shouldn't be using these anymore, but prefer better options for testing their remote requests.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

BREAKING CHANGE: remove fakeXMLHttpRequest and fakeServer from the API
@mroderick mroderick added the semver:major changes will cause a new major version label Mar 17, 2025
Copy link

socket-security bot commented Mar 17, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (7af1d23) to head (9a7967b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2642      +/-   ##
==========================================
- Coverage   96.09%   96.03%   -0.06%     
==========================================
  Files          40       40              
  Lines        1944     1919      -25     
==========================================
- Hits         1868     1843      -25     
  Misses         76       76              
Flag Coverage Δ
unit 96.03% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's time. We might want to add some notes to the migration-guide.md about alternatives (msw, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:major changes will cause a new major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants